(feat) Adds request rate limit throttling to Injective Perpetual #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #39661: Add requests throttling to Injective Perpetual. |
aarmoa
suggested changes
May 3, 2023
Comment on lines
95
to
96
| SECOND = 1 | ||
| MINUTE = 60 |
There was a problem hiding this comment.
Please use the globals in hummingbot.connector.constants instead of defining them here
rxlxrxsx
approved these changes
May 5, 2023
There was a problem hiding this comment.
Tested and confirmed working by QA.
- Connected API keys and confirmed working as expected
- Confirmed wallet and exchange balances are reflecting correct
- Created a perpetual_mm strategy and went through initial prompts successfully
- Started the strategy without issues, confirmed orders are created and cancelled based on config
- Confirmed order book prices is in sync with the exchange
- Confirmed positions are detected whenever it’s opened or closed
- Confirmed funding payment is being received by the bot
- Trade information are correct based on history command output
- Compared trades in client and exchange, no discrepancies found
- Confirmed running on multiple order levels works as expected
|
Closing to re-open towards foundation: hummingbot#6283 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting this PR, please make sure:
A description of the changes proposed in the pull request:
This PR introduces rate limiting for Injective perpetual connector SDK calls.
The rate limits are 120 requests per minute per service (gRPC vs HTTP), and only chain calls are limited, with indexer calls being unrestricted.
Tests performed by the developer:
Manually tested that the connector works after the introduction of the changes.
Tips for QA testing:
Please test the connector's operation for several cycles (at least 5m) with several order levels. The rate limits are on 1s basis, so we really just need to make sure that the rate limits are not impairing the connector's operation during any periods of high requests, like during the status polling loop.
[ch-39661]